Support for NixOS #130
Merged
Support for NixOS #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| valgrind | ||
| man | ||
| groff | ||
| imagemagick |
There was a problem hiding this comment.
Why do we have imagemagick, graphviz, clang-tools, and bear in here? I realize they may be useful for debugging LOST, does nix have a more idiomatic way of saying "create a development shell for this project, except also install these packages" rather than hardcoding potentially-useful dependencies into this flake file?
There was a problem hiding this comment.
These all do go into the devShell. The actual binary is built using the nix/package.nix where we define nativeBuildInputs (dependencies for building) and buildInputs (runtime dependencies).
markasoftware
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
flake.nix,shell.nixandnix/package.nixfor a Nix development shell and packaging.It's nice to have when working on a Nix system.